Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 2, 2022

Resolve #42

@leynier leynier added the enhancement New feature or request label Jan 2, 2022
@leynier leynier requested a review from a team January 2, 2022 17:56
@dreinon dreinon requested a review from anand2312 January 2, 2022 18:09
@leynier leynier requested a review from dreinon January 2, 2022 18:18
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.25%.

Quality metrics Before After Change
Complexity 0.49 ⭐ 0.55 ⭐ 0.06 👎
Method Length 28.28 ⭐ 27.95 ⭐ -0.33 👍
Working memory 5.16 ⭐ 5.46 ⭐ 0.30 👎
Quality 88.94% 89.19% 0.25% 👍
Other metrics Before After Change
Lines 618 624 6
Changed files Quality Before Quality After Quality Change
postgrest_py/base_request_builder.py 86.82% ⭐ 86.77% ⭐ -0.05% 👎
postgrest_py/_async/request_builder.py 90.50% ⭐ 88.17% ⭐ -2.33% 👎
postgrest_py/_sync/request_builder.py 90.52% ⭐ 88.18% ⭐ -2.34% 👎
tests/_async/test_request_builder.py 92.64% ⭐ 92.64% ⭐ 0.00%
tests/_sync/test_request_builder.py 92.64% ⭐ 92.64% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@dreinon dreinon merged commit 8728ee8 into supabase:master Jan 2, 2022
@leynier leynier deleted the feat/add-return-mode-like-a-parameter branch January 4, 2022 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add return mode like a parameter

2 participants