Skip to content

fix: allow postgres to grant storage privs to other roles #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2025
Merged

fix: allow postgres to grant storage privs to other roles #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
368343c
fix: allow postgres to grant storage privs to other roles
soedirgo Jun 23, 2025
29aa02a
Merge branch 'develop' into fix/postgres-storage-grants
soedirgo Jun 24, 2025
52945d1
Merge branch 'develop' into fix/postgres-storage-grants
soedirgo Jun 25, 2025
f9b2745
chore: bump AMI versions
soedirgo Jun 25, 2025
79a8bf1
Merge branch 'develop' into fix/postgres-storage-grants
soedirgo Jun 26, 2025
d53119d
chore: bump AMI versions
soedirgo Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ansible/vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ postgres_major:

# Full version strings for each major version
postgres_release:
postgresorioledb-17: "17.0.1.097-orioledb"
postgres17: "17.4.1.47"
postgres15: "15.8.1.104"
postgresorioledb-17: "17.0.1.098-orioledb"
postgres17: "17.4.1.048"
postgres15: "15.8.1.105"

# Non Postgres Extensions
pgbouncer_release: "1.19.0"
Expand Down
6 changes: 6 additions & 0 deletions ...s/db/migrations/20250623125453_tmp_grant_storage_tables_to_postgres_with_grant_option.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
-- migrate:up
-- TODO: remove this migration once STORAGE-211 is completed
-- DRI: bobbie
grant all on storage.buckets, storage.objects to postgres with grant option;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest an ALTER DEFAULT PRIVILEGES instead, to not worry about future objects created on the storage schema:

alter default privileges for user supabase_storage_admin in schema storage grant all
    on tables to postgres with grant option;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want all Storage tables to have these grants, only these ones.


-- migrate:down
28 changes: 14 additions & 14 deletions nix/tests/expected/storage.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ order by
storage | buckets | authenticated | TRIGGER | f
storage | buckets | authenticated | TRUNCATE | f
storage | buckets | authenticated | UPDATE | f
storage | buckets | postgres | DELETE | f
storage | buckets | postgres | INSERT | f
storage | buckets | postgres | REFERENCES | f
storage | buckets | postgres | SELECT | f
storage | buckets | postgres | TRIGGER | f
storage | buckets | postgres | TRUNCATE | f
storage | buckets | postgres | UPDATE | f
storage | buckets | postgres | DELETE | t
storage | buckets | postgres | INSERT | t
storage | buckets | postgres | REFERENCES | t
storage | buckets | postgres | SELECT | t
storage | buckets | postgres | TRIGGER | t
storage | buckets | postgres | TRUNCATE | t
storage | buckets | postgres | UPDATE | t
storage | buckets | service_role | DELETE | f
storage | buckets | service_role | INSERT | f
storage | buckets | service_role | REFERENCES | f
Expand Down Expand Up @@ -123,13 +123,13 @@ order by
storage | objects | authenticated | TRIGGER | f
storage | objects | authenticated | TRUNCATE | f
storage | objects | authenticated | UPDATE | f
storage | objects | postgres | DELETE | f
storage | objects | postgres | INSERT | f
storage | objects | postgres | REFERENCES | f
storage | objects | postgres | SELECT | f
storage | objects | postgres | TRIGGER | f
storage | objects | postgres | TRUNCATE | f
storage | objects | postgres | UPDATE | f
storage | objects | postgres | DELETE | t
storage | objects | postgres | INSERT | t
storage | objects | postgres | REFERENCES | t
storage | objects | postgres | SELECT | t
storage | objects | postgres | TRIGGER | t
storage | objects | postgres | TRUNCATE | t
storage | objects | postgres | UPDATE | t
storage | objects | service_role | DELETE | f
storage | objects | service_role | INSERT | f
storage | objects | service_role | REFERENCES | f
Expand Down
Loading