Skip to content

Conversation

laktek
Copy link
Contributor

@laktek laktek commented Jul 1, 2025

  • Updated FunctionsClient to add region as both x-region header and forceFunctionRegion query param
  • Used URL API to properly construct query parameters
  • Added comprehensive tests to verify both header and query parameter functionality
  • Updated existing test to check for both region mechanisms
  • Maintains backward compatibility with existing x-region header

🤖 Generated with Claude Code

@laktek laktek requested a review from grdsdev July 1, 2025 11:17
- Updated FunctionsClient to add region as both x-region header and forceFunctionRegion query param
- Used URL API to properly construct query parameters
- Added comprehensive tests to verify both header and query parameter functionality
- Updated existing test to check for both region mechanisms
- Maintains backward compatibility with existing x-region header

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@laktek laktek force-pushed the add-region-query-param branch from 6d0ee93 to 3d7cba0 Compare July 1, 2025 12:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15999046635

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 92.308%

Totals Coverage Status
Change from base Build 14485318779: 0.09%
Covered Lines: 222
Relevant Lines: 235

💛 - Coveralls

@laktek laktek merged commit 8da7c47 into main Jul 1, 2025
3 checks passed
@laktek laktek deleted the add-region-query-param branch July 1, 2025 12:26
@grdsdev grdsdev changed the title Add region as forceFunctionRegion query parameter feat: Add region as forceFunctionRegion query parameter Jul 1, 2025
grdsdev added a commit to supabase/supabase-py that referenced this pull request Sep 30, 2025
- Updated FunctionsClient (both async and sync) to add region as both x-region header and forceFunctionRegion query param
- Used urllib.parse.urlencode to properly construct query parameters
- Added comprehensive tests to verify both header and query parameter functionality
- Updated existing tests to check for both region mechanisms
- Maintains backward compatibility with existing x-region header

Ported from supabase/functions-js#100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
grdsdev added a commit to supabase/supabase-flutter that referenced this pull request Sep 30, 2025
- Add region parameter to FunctionsClient constructor and invoke method
- When region is specified and not 'any', adds both x-region header and forceFunctionRegion query parameter
- Add FunctionsClientOptions to SupabaseClient for configuring default region
- Add comprehensive tests for region functionality
- Maintain backward compatibility with existing code

This feature ports the functionality from functions-js PR #100:
supabase/functions-js#100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
grdsdev added a commit to supabase/supabase-swift that referenced this pull request Sep 30, 2025
- Updated FunctionsClient to add region as both x-region header and forceFunctionRegion query param
- Updated tests to verify both header and query parameter functionality
- Maintains backward compatibility with existing x-region header

Ported from supabase/functions-js#100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
grdsdev added a commit to supabase/supabase-flutter that referenced this pull request Sep 30, 2025
* feat: add region as forceFunctionRegion query parameter

- Add region parameter to FunctionsClient constructor and invoke method
- When region is specified and not 'any', adds both x-region header and forceFunctionRegion query parameter
- Add FunctionsClientOptions to SupabaseClient for configuring default region
- Add comprehensive tests for region functionality
- Maintain backward compatibility with existing code

This feature ports the functionality from functions-js PR #100:
supabase/functions-js#100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* add region to log

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants