Skip to content

feat: mailer logging #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat: mailer logging #1805

merged 4 commits into from
Oct 15, 2024

Conversation

@cstockton
Copy link
Contributor

@cstockton cstockton commented Oct 14, 2024

This is a quick patch to add basic logging information to the mailer package.

I wasn't sure how to only log this information when using the Supabase default mail provider without adding another custom config flag to enable it.

feat: mailer logging
d970061 
This is a quick patch to add basic logging information to the
mailer package.

I wasn't sure how to only log this information when using the
supabase default mail provider without adding another custom
config flag to enable it.
@cstockton cstockton requested a review from a team as a code owner October 14, 2024 23:35
@coveralls
Copy link

coveralls commented Oct 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11348418889

Details

  • 7 of 32 (21.88%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 57.189%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/mailer/template.go 6 7 85.71%
internal/mailer/mailer.go 0 9 0.0%
internal/mailer/mailme.go 0 15 0.0%
Totals Coverage Status
Change from base Build 11334620572: -0.04%
Covered Lines: 9550
Relevant Lines: 16699
💛 - Coveralls

kangmingtay
kangmingtay reviewed Oct 15, 2024
View reviewed changes
J0
J0 reviewed Oct 15, 2024
View reviewed changes
hf
hf reviewed Oct 15, 2024
View reviewed changes
@cstockton cstockton merged commit 9354b83 into master Oct 15, 2024
2 checks passed
@cstockton cstockton deleted the cs/feat-mailer-logging branch October 15, 2024 16:16
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Merged
cstockton pushed a commit that referenced this pull request Oct 15, 2024
@github-actions
chore(master): release 2.163.0 (#1794)
14b375f 
🤖 I have created a release *beep* *boop*
---


##
[2.163.0](v2.162.2...v2.163.0)
(2024-10-15)


### Features

* add mail header support via `GOTRUE_SMTP_HEADERS` with `$messageType`
([#1804](#1804))
([99d6a13](99d6a13))
* add MFA for WebAuthn
([#1775](#1775))
([8cc2f0e](8cc2f0e))
* configurable email and sms rate limiting
([#1800](#1800))
([5e94047](5e94047))
* mailer logging ([#1805](#1805))
([9354b83](9354b83))
* preserve rate limiters in memory across configuration reloads
([#1792](#1792))
([0a3968b](0a3968b))


### Bug Fixes

* add twilio verify support on mfa
([#1714](#1714))
([aeb5d8f](aeb5d8f))
* email header setting no longer misleading
([#1802](#1802))
([3af03be](3af03be))
* enforce authorized address checks on send email only
([#1806](#1806))
([c0c5b23](c0c5b23))
* fix `getExcludedColumns` slice allocation
([#1788](#1788))
([7f006b6](7f006b6))
* Fix reqPath for bypass check for verify EP
([#1789](#1789))
([646dc66](646dc66))
* inline mailme package for easy development
([#1803](#1803))
([fa6f729](fa6f729))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@cstockton @cemalkilic
feat: mailer logging (#1805)
4756ff8 
This is a quick patch to add basic logging information to the mailer
package.

I wasn't sure how to only log this information when using the Supabase
default mail provider without adding another custom config flag to
enable it.

---------

Co-authored-by: Chris Stockton <[email protected]>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@github-actions @cemalkilic
chore(master): release 2.163.0 (#1794)
443abc9 
🤖 I have created a release *beep* *boop*
---


##
[2.163.0](v2.162.2...v2.163.0)
(2024-10-15)


### Features

* add mail header support via `GOTRUE_SMTP_HEADERS` with `$messageType`
([#1804](#1804))
([99d6a13](99d6a13))
* add MFA for WebAuthn
([#1775](#1775))
([8cc2f0e](8cc2f0e))
* configurable email and sms rate limiting
([#1800](#1800))
([5e94047](5e94047))
* mailer logging ([#1805](#1805))
([9354b83](9354b83))
* preserve rate limiters in memory across configuration reloads
([#1792](#1792))
([0a3968b](0a3968b))


### Bug Fixes

* add twilio verify support on mfa
([#1714](#1714))
([aeb5d8f](aeb5d8f))
* email header setting no longer misleading
([#1802](#1802))
([3af03be](3af03be))
* enforce authorized address checks on send email only
([#1806](#1806))
([c0c5b23](c0c5b23))
* fix `getExcludedColumns` slice allocation
([#1788](#1788))
([7f006b6](7f006b6))
* Fix reqPath for bypass check for verify EP
([#1789](#1789))
([646dc66](646dc66))
* inline mailme package for easy development
([#1803](#1803))
([fa6f729](fa6f729))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@cstockton @xeladotbe
feat: mailer logging (supabase#1805)
164058f 
This is a quick patch to add basic logging information to the mailer
package.

I wasn't sure how to only log this information when using the Supabase
default mail provider without adding another custom config flag to
enable it.

---------

Co-authored-by: Chris Stockton <[email protected]>
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@github-actions @xeladotbe
chore(master): release 2.163.0 (supabase#1794)
ec6824b 
🤖 I have created a release *beep* *boop*
---


##
[2.163.0](supabase/auth@v2.162.2...v2.163.0)
(2024-10-15)


### Features

* add mail header support via `GOTRUE_SMTP_HEADERS` with `$messageType`
([supabase#1804](supabase#1804))
([99d6a13](supabase@99d6a13))
* add MFA for WebAuthn
([supabase#1775](supabase#1775))
([8cc2f0e](supabase@8cc2f0e))
* configurable email and sms rate limiting
([supabase#1800](supabase#1800))
([5e94047](supabase@5e94047))
* mailer logging ([supabase#1805](supabase#1805))
([9354b83](supabase@9354b83))
* preserve rate limiters in memory across configuration reloads
([supabase#1792](supabase#1792))
([0a3968b](supabase@0a3968b))


### Bug Fixes

* add twilio verify support on mfa
([supabase#1714](supabase#1714))
([aeb5d8f](supabase@aeb5d8f))
* email header setting no longer misleading
([supabase#1802](supabase#1802))
([3af03be](supabase@3af03be))
* enforce authorized address checks on send email only
([supabase#1806](supabase#1806))
([c0c5b23](supabase@c0c5b23))
* fix `getExcludedColumns` slice allocation
([supabase#1788](supabase#1788))
([7f006b6](supabase@7f006b6))
* Fix reqPath for bypass check for verify EP
([supabase#1789](supabase#1789))
([646dc66](supabase@646dc66))
* inline mailme package for easy development
([supabase#1803](supabase#1803))
([fa6f729](supabase@fa6f729))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@cstockton @issuedat
feat: mailer logging (#1805)
0ba8659 
This is a quick patch to add basic logging information to the mailer
package.

I wasn't sure how to only log this information when using the Supabase
default mail provider without adding another custom config flag to
enable it.

---------

Co-authored-by: Chris Stockton <[email protected]>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@github-actions @issuedat
chore(master): release 2.163.0 (#1794)
9f0e738 
🤖 I have created a release *beep* *boop*
---


##
[2.163.0](v2.162.2...v2.163.0)
(2024-10-15)


### Features

* add mail header support via `GOTRUE_SMTP_HEADERS` with `$messageType`
([#1804](#1804))
([99d6a13](99d6a13))
* add MFA for WebAuthn
([#1775](#1775))
([8cc2f0e](8cc2f0e))
* configurable email and sms rate limiting
([#1800](#1800))
([5e94047](5e94047))
* mailer logging ([#1805](#1805))
([9354b83](9354b83))
* preserve rate limiters in memory across configuration reloads
([#1792](#1792))
([0a3968b](0a3968b))


### Bug Fixes

* add twilio verify support on mfa
([#1714](#1714))
([aeb5d8f](aeb5d8f))
* email header setting no longer misleading
([#1802](#1802))
([3af03be](3af03be))
* enforce authorized address checks on send email only
([#1806](#1806))
([c0c5b23](c0c5b23))
* fix `getExcludedColumns` slice allocation
([#1788](#1788))
([7f006b6](7f006b6))
* Fix reqPath for bypass check for verify EP
([#1789](#1789))
([646dc66](646dc66))
* inline mailme package for easy development
([#1803](#1803))
([fa6f729](fa6f729))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf hf hf left review comments

@kangmingtay kangmingtay kangmingtay approved these changes

+1 more reviewer

@J0 J0 J0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cstockton @coveralls @hf @J0 @kangmingtay