Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

s-bridges
Copy link

@s-bridges s-bridges commented Jun 30, 2025

What kind of change does this PR introduce?

Bug fix - corrects dependency classification

What is the current behavior?

TypeScript compilation fails for users with the error:

Cannot find module '@solana/wallet-standard-features' or its corresponding type declarations

This happens because @solana/wallet-standard-features is imported in src/lib/types.ts but is incorrectly placed in devDependencies. When users install @supabase/auth-js, they don't get dev dependencies, causing the TypeScript compiler to fail when it encounters the missing module.

What is the new behavior?

TypeScript compilation works correctly. The @solana/wallet-standard-features package is now properly classified as a runtime dependency, making it available to all users who install @supabase/auth-js.

Users no longer need to manually install the missing dependency as a workaround.

Additional context

@s-bridges s-bridges changed the title Fix: Move @solana/wallet-standard-features to dependencies fix: Move @solana/wallet-standard-features to dependencies Jun 30, 2025
@hf
Copy link
Contributor

hf commented Jul 9, 2025

It's probably better to inline the type and get rid of the dependency

@hf
Copy link
Contributor

hf commented Jul 9, 2025

Alternative option here #1079

Thank you for this PR though! It helps a lot! Feel free to contribute again!

@hf hf closed this Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript compilation fails: @solana/wallet-standard-features in wrong dependency section

2 participants