Mass assignment #19
Merged
Mass assignment #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rails 3.2.8, mass assignment can mean that the ActiveModel class doesn't support mass assignment. This change ignores any such protection and assumes it's your own data and you know what you're doing with it.
Initial exploration seemed to point to a mass-assignment issue; this change adds a test which attempts to reproduce the configuration that rails is using when running the application that fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
This might not be the correct fix (someone with better knowledge of rails than I can judge), but it does have a failing test and a change which fixes the test, plus the change works in our production environment to extract the data and cleanse it for us.