This repository was archived by the owner on Jul 7, 2022. It is now read-only.
symbols: put data symbols into namespace 1 and funcs into 0 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me. |
Before this change we but everything into namespace 0 (so is_function() always return true).
`cranelift-simplejit/src/backend.rs::get_definition:`
calls `namespace.is_function(name)` to figure out if it has to lookup a function or data definition.
But cranelift-module is_function() does this by comparing the namespace with 0:
```
// Return whether `name` names a function, rather than a data object.
pub fn is_function(&self, name: &ir::ExternalName) -> bool {
if let ir::ExternalName::User { namespace, .. } = *name {
namespace == 0
} else {
panic!("unexpected ExternalName kind {}", name)
}
}
```
undingen
force-pushed
the
global_namespace
branch
from
53c8329 to
ba3e57e
Compare
|
rebased the PR - no other changes |
|
is there anything to do to get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we but everything into namespace 0 (so is_function() always returned true).
cranelift-simplejit/src/backend.rs::get_definition:calls
namespace.is_function(name)to figure out if it has to lookup a function or data definition.But cranelift-module is_function() does this by comparing the namespace with 0: