This repository was archived by the owner on Jul 7, 2022. It is now read-only.
fix panic when encountering memcpy, memset, memove intrinsics #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Oct 2, 2019
when encountering the example below we rewrote the intrinsics name to e.g. "memcpy" but because this string was likely not yet in string table get_extname() asserted. Instead of manually creating the string table entries I decided to start moving to the ExternalName::LibCall functionality. I did not want to introduce an new dependency on cranelift-module (and also didn't want to add the `Box<dyn Fn(ir::LibCall)>` everywhere) so instead I hardcoded the name of the three functions for now. ```llvm define dso_local void @foo(i8* nocapture readonly, i8* nocapture, i8* nocapture, i8* nocapture) local_unnamed_addr { tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* align 1 %1, i8* align 1 %0, i64 42, i1 false) tail call void @llvm.memmove.p0i8.p0i8.i64(i8* align 1 %2, i8* align 1 %0, i64 42, i1 false) tail call void @llvm.memset.p0i8.i64(i8* align 1 %3, i8 0, i64 42, i1 false) ret void } declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i1) declare void @llvm.memmove.p0i8.p0i8.i64(i8* nocapture, i8* nocapture readonly, i64, i1) declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1) ```
|
Thanks for the review. I removed the changes in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when encountering the example below we rewrote the intrinsics name to e.g.
memcpybut because this string was likely not yet in string tableget_extname()asserted. Instead of manually creating the string table entries I decided to start moving to theExternalName::LibCallfunctionality.I did not want to introduce an new dependency on cranelift-module (and also didn't want to add the
Box<dyn Fn(ir::LibCall)>everywhere)so instead I hardcoded the name of the three functions for now.