Added support to resize remote image: #16 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A path is 'remote' if net.url.Parse(path).Scheme is not empty. TwoTier.RemoteLocalPath convert URL to local path which is then use for storage,cache and thumbnails.
sudokai
requested changes
Nov 19, 2018
| return s.Cache.LoadCache(walkFn) | ||
| } | ||
|
|
||
| func (s *TwoTier) RemoteToLocalPath(path string) (string, bool) { |
Owner
There was a problem hiding this comment.
Suggested change
| func (s *TwoTier) RemoteToLocalPath(path string) (string, bool) { | |
| func (s *TwoTier) remoteToLocalPath(path string) (string, bool) { |
Unexport this function.
Owner
|
Sorry again for the delays, I'm working on a rewrite of the caching layer and won't be available until I finish that. I will come back to this PR as soon as possible. |
Collaborator
Author
|
No problem, I really understand since I'm also quite busy with work on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A path is 'remote' if net.url.Parse(path).Scheme is not empty.
TwoTier.RemoteLocalPath convert URL to local path which is then use for storage,cache and thumbnails.
Since I'm far from an expert level in golang, I'm not sure this is the right way to handle this part.
Please note this a work in progress since I think that security is not handled with this patch.