Skip to content

added support for mysql #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added support for mysql #4

wants to merge 2 commits into from

Conversation

xtrycatchx
Copy link
Contributor

  • Modified README.md to add instructions when one is using MySQL as choice of persistence
  • Added mysql in dependency in package.json
  • Added MySQL script for schema and table creation in db/mysql/todo-subsecond.sql

aslakhellesoy
aslakhellesoy requested changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide the commands required to create a database as well?

README.md Outdated
@@ -45,7 +45,7 @@ The techniques illustrated by this application are inspired by:

Although this repository is intended as a demonstration of a design pattern, we want it to be as realistic as possible. So ideally you should use a database that you might use in production, like the [instance we deployed with a postgres database](https://todo-subsecond.herokuapp.com).

If you have Postgres installed you can use that. Otherwise you can use SQlite (this is simpler as it does not require a separate installation):
If you have Postgres installed you can use that. Otherwise you can use MySQL or SQlite (this is simpler as it does not require a separate installation):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL will require installation just like Postgres.

@xtrycatchx
Copy link
Contributor Author

Pushed commands to create MySQL db schema :)

@joshski
Copy link
Contributor

joshski commented Nov 12, 2017

Hi @xtrycatchx,

Thanks for your contribution. I don't use mysql much, but I tried installing mysql with homebrew, then running your example and it didn't work.

➜  todo-subsecond git:(mysql-support) mysql -u username -p < db/mysql/todo-subsecond.sql
Enter password: 
ERROR 1045 (28000): Access denied for user 'username'@'localhost' (using password: NO)

It's quite possible that mysql users will know how to deal with this, but we really wanted to keep the examples as "idiot proof" as possible and for me at least, both the postgres and sqlite versions "just work" with no additional instructions.

Is there anything we can do to make it less likely to fail? (I see you have specified username as the database user, for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakhellesoy aslakhellesoy aslakhellesoy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtrycatchx @joshski @aslakhellesoy