Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Extensions should be more dynamic #819

@stephanvierkant

Description

@stephanvierkant

I'd like to use the FixedColumns extension, but that requires changing \Sg\DatatablesBundle\Datatable\Extensions and Resources/views/datatable/extensions.html.twig.

I can create a PR to add this feature, but I feel like this shouldn't be needed. I love OOP, but this seems over engineered. Configuring the OptionsResolver and using Twig to generate JSON is quite overkill, isn't it?

As an example, see 87d122c. It's a very complex, inflexible and over-engineered way of printing a JSON string.

Replacing \Sg\DatatablesBundle\Datatable\Extensions by an array makes more sense. Datatables.net's JS library should be use to handle configuration errors in this case.

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions