Skip to content

chore: improve issue and PR templates #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

chore: improve issue and PR templates #101

merged 1 commit into from
Nov 21, 2019

Conversation

@nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Nov 16, 2019 •
edited
Loading

Description

Improve issue and pull request templates.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir nabdelgadir requested a review from bajtos as a code owner November 16, 2019 00:47
@nabdelgadir nabdelgadir self-assigned this Nov 16, 2019
@bajtos bajtos mentioned this pull request Nov 16, 2019
Closed
28 tasks
@nabdelgadir nabdelgadir force-pushed the chore/improve-issue-templates branch from bed9814 to 1ba2922 Compare November 16, 2019 02:00
@nabdelgadir
Copy link
Contributor Author

nabdelgadir commented Nov 16, 2019

See #102 for linter fixes

dhmlau
dhmlau requested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabdelgadir , i think we'd still want users to open bugs/features for connector specific issues in here instead of against the loopback-next repo. So maybe we can use PR https://github.com/strongloop/loopback-connector-mongodb/pull/551/files as a reference? Thanks.

@nabdelgadir
Copy link
Contributor Author

nabdelgadir commented Nov 17, 2019 •
edited
Loading

@nabdelgadir , i think we'd still want users to open bugs/features for connector specific issues in here instead of against the loopback-next repo. So maybe we can use PR https://github.com/strongloop/loopback-connector-mongodb/pull/551/files as a reference? Thanks.

@dhmlau This one's using the connector specific one, but I have to update the mongodb one instead. nvm I see what you mean. I'll update this to match mongodb 👍

@nabdelgadir nabdelgadir force-pushed the chore/improve-issue-templates branch from 1ba2922 to edd1bbb Compare November 19, 2019 16:23
@nabdelgadir nabdelgadir force-pushed the chore/improve-issue-templates branch from edd1bbb to 4f8a372 Compare November 19, 2019 16:25
@nabdelgadir nabdelgadir merged commit 4bfa461 into master Nov 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/improve-issue-templates branch November 21, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau dhmlau requested changes

@agnes512 agnes512 agnes512 approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees

@nabdelgadir nabdelgadir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nabdelgadir @dhmlau @agnes512