Fix scrollbars on MacOS #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if it's intentional or not, but when I look at the preview, the scroll bar stays in light mode when the site is in dark mode (both for the search dialog and the main page). I looked in Chrome, Firefox, and Safari on MacOS.
|
sfc-gh-dmatthews
approved these changes
Aug 20, 2023
snehankekre
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR fixes an issue reported by @sfc-gh-tteixeira where the Algolia popup would not have its right corners rounded.
🧠 Description of Changes
The main reason for this was that some styles we added for our scrollbars, which were meant to be applied on Windows machines, were also "leaking" on Mac computers as well. The reason for this was that our code was checking for platforms that were called
Mac, but now that Apple also hasMacIntelplatforms, we need to ensure we accommodate for both scenarios. Changes made where:pages/_app.jsto check if the wordMacis present on thenavigator.platformprop, instead of strictly checking for it to beMaconly;scrollbars.scss:not(.mac)selectorRevised:
Kapture.2023-08-18.at.16.39.42.mp4
Current:
Kapture.2023-08-18.at.16.40.43.mp4
💥 Impact
Size:
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.