Skip to content

Remove note on secondary background color for ploty #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

jrieke
Copy link
Collaborator

@jrieke jrieke commented Jan 12, 2023

📚 Context

The docs state that we use the secondary background color as the background for Plotly charts. But we don't do this anymore with the new charting them.

🧠 Description of Changes

  • Removing the sentence.
  • Might be good to also update the screenshot but I don't have the underlying app.

Revised:

(Leaving this out since it's a one-liner).

Current:

💥 Impact

Size:

  • Small
  • Not small

🌐 References

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snehankekre snehankekre self-requested a review January 12, 2023 16:46
Copy link
Contributor

@snehankekre snehankekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got to it before I could 😄 Thank you!

@snehankekre snehankekre merged commit 206a4df into streamlit:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants