Skip to content

Conversation

@JackYPCOnline
Copy link
Contributor

Description

fix the bug that non-interactive mode run infinitely in integration test

  • Dual-Mode Operation: Added comprehensive support for both interactive and non-interactive execution through a new non_interactive_mode parameter
  • Process Group Management: Improved command execution with better process isolation using os.setsid() for cleaner termination
  • Terminal State Safety: Enhanced terminal settings handling to prevent issues in headless environments
  • Signal Handling: Improved process termination with proper process group signaling
  • Simplified API: Streamlined command normalization for more consistent behavior
  • Update unit tests

Related Issues

[Link to related issues using #issue-number format]

Documentation PR

[Link to related associated PR in the agent-docs repo]

Type of Change

  • [ x] Bug fix
  • New Tool
  • Breaking change
  • Other (please describe):

Testing

[How have you tested the change?]
Yes. Unit tests and start strands agent.

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all

Checklist

  • [ x] I have read the CONTRIBUTING document

  • [ x] I have added tests that prove my fix is effective or my feature works

  • [ x] I have updated the documentation accordingly

  • [ x] I have added an appropriate example to the documentation to outline the feature

  • [ x] My changes generate no new warnings

  • [ x] Any dependent changes have been merged and published

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JackYPCOnline JackYPCOnline requested a review from a team as a code owner June 12, 2025 05:06
@JackYPCOnline
Copy link
Contributor Author

also tested with integration test with different interactive mode and termination.

Copy link
Member

@zastrowm zastrowm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions, but don't see major blockers

@JackYPCOnline JackYPCOnline merged commit 618fa0d into strands-agents:main Jul 21, 2025
14 checks passed
@JackYPCOnline JackYPCOnline deleted the bug-fix branch September 29, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants