generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 449
hooks - before tool call event - cancel tool #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unshure
reviewed
Oct 2, 2025
zastrowm
requested changes
Oct 3, 2025
zastrowm
approved these changes
Oct 3, 2025
Unshure
approved these changes
Oct 3, 2025
8 tasks
JackYPCOnline
added a commit
that referenced
this pull request
Oct 10, 2025
* feat: replace kwargs with invocation_state in agent APIs * fix: handle **kwargs in stream_async. * feat: add a unit test for the change * Update src/strands/agent/agent.py Co-authored-by: Nick Clegg <[email protected]> * tool - executors - concurrent - remove no-op gather (#954) * feat(telemetry): updated traces to match OTEL v1.37 semantic conventions (#952) * event loop - handle model execution (#958) * feat: implement concurrent message reading for session managers (#897) Replace sequential message loading with async concurrent reading in both S3SessionManager and FileSessionManager to improve performance for long conversations. Uses asyncio.gather() with run_in_executor() to read multiple messages simultaneously while maintaining proper ordering. Resolves: #874 Co-authored-by: Vamil Gandhi <[email protected]> * hooks - before tool call event - cancel tool (#964) * fix(telemetry): removed double serialization for events (#977) * fix(litellm): map LiteLLM context-window errors to ContextWindowOverflowException (#994) * feat: add more tests and adjust invocation_state dic structure * Apply suggestion from @Unshure Co-authored-by: Nick Clegg <[email protected]> * fix: adjust **kwargs in multiagent primitives --------- Co-authored-by: Nick Clegg <[email protected]> Co-authored-by: Patrick Gray <[email protected]> Co-authored-by: poshinchen <[email protected]> Co-authored-by: Vamil Gandhi <[email protected]> Co-authored-by: Vamil Gandhi <[email protected]> Co-authored-by: ratish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support cancelling tool calls from a
BeforeToolCallEventhook. This feature is meant to compliment interrupts as part of the human-in-the-loop (HIL) process. The idea is that if a customer interrupts a tool for human approval and that human sends back a rejection, the tool call will be cancelled. This however could also be extended to use cases outside of HIL.Usage
If rejected, the tool will not execute and the tool result will look as follows:
{ "toolUseId": "delete_tool", "status": "error", "content": [{"text": "tool rejected"}], }Note, this cancellation does not stop the agent loop. It strictly prevents the given tool from executing. Any other tools executing in sequence or concurrently will continue to do so. All results (including the cancel result) are sent to the model on the next iteration of the agent loop.
Related Issues
#204
Documentation PR
Will follow up on this after all the HIL changes are merged.
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare: Wrote new unit tests.hatch test tests_integ/tools/executors/*.py: Wrote new integ tests.Checklist
Follow up
The SequentialToolExecutor will execute all tools in sequence even if one fails. Support for cancellation got me thinking that maybe we want to break out of execution if a tool fails since the SequentialToolExecutor is meant to set an order/dependency between calls.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.