fix(gemini): Fix event loop closed error from Gemini asyncio #932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical issue where the Gemini model provider would fail with
RuntimeError: Event loop is closed
when used in multi-turn conversations. The problem occurred when multiple synchronous agent calls were made sequentially, each creating a new event loop viaasyncio.run()
.Root Cause
The original implementation stored a single
genai.Client
instance during initialization, which would bind its underlying HTTP session (aiohttp) to the first event loop. When subsequent calls created new event loops, the old HTTP session would attempt to use the closed event loop, causing the runtime error.Solution
Changed the Gemini model to create a fresh client for each async operation instead of reusing a single instance:
Before:
After:
Related Issues
Fixes the failing
test_agent_invoke_multiturn
test in the Gemini model integration tests. This issue is related to a known upstream problem in the Google genai SDK regarding connection pooling performance (googleapis/python-genai#516).Documentation PR
No documentation changes required - this is an internal implementation fix that maintains the same public API.
Type of Change
Bug fix
Testing
How have you tested the change?
test_agent_invoke_multiturn
test now passesVerify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.