feat: add supports_hot_reload property to PythonAgentTool #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add supports_hot_reload property that returns True for function-based tools - This enables proper hot reload support for TOOL_SPEC + function() pattern tools - Aligns with the conditional check in PR strands-agents#772 for tool reloading logic
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
JackYPCOnline
previously approved these changes
Sep 25, 2025
…entTool - Update test_supports_hot_reload to expect True (PythonAgentTool now supports hot reload) - Fix test_register_tool_duplicate_name_without_hot_reload to use mocked tools without hot reload support - Add missing patch import in test_registry.py
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mkmeral
approved these changes
Sep 26, 2025
zastrowm
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in our module based tools, we're not setting the
supports_hot_reloadproperty, which leads to not hot-reload those tools.Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.