fix: Invoke callback handler for structured_output #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the switch to typed_events, the case of structured_output invoking the callback handler was missed, resulting in a break in backwards compatibility (see issue #831); this restores the old behavior/fixes backwards compatibility
Important
I'm not sure we want this behavior
I'm not entirely convinced we want this behavior - compared to the other callback handlers, the events emitted from
Agent.structured_output
are very provider & implementation-specific. For instance:I would like to discuss further with the team regarding the issue; I see a couple of paths forward:
Testing
I tested the events emitted before and after typed events were introduced and the test passed in both cases.
Related Issues
#831
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.