fix: correctly label tool result messages in OpenTelemetry events #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamgan
had a problem deploying
to
manual-approval
GitHub Actions
Failure
zastrowm
previously approved these changes
Sep 15, 2025
dbschmigelski
requested changes
Sep 15, 2025
- Label messages containing tool results as 'gen_ai.tool.message' regardless of role - Add OpenTelemetry semantic conventions v1.36.0 reference - Note that GenAI namespace is experimental - Add documentation link to semantic conventions - Convert tests to data-driven parametrized format for better maintainability - Improve test coverage with comprehensive edge cases including mixed content and multiple tool results
vamgan
force-pushed
the
fix/opentelemetry-tool-message-event-type
branch
from
6c8c6e7 to
84468d2
Compare
vamgan
had a problem deploying
to
manual-approval
GitHub Actions
Failure
dbschmigelski
approved these changes
Sep 15, 2025
zastrowm
approved these changes
Sep 15, 2025
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
… events (strands-agents#839) Co-authored-by: Vamil Gandhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tool result messages were incorrectly labeled as 'gen_ai.user.message' in OpenTelemetry traces. This fix adds proper detection of tool results in message content and labels them as 'gen_ai.tool.message' according to OpenTelemetry semantic conventions.
Related Issues
Fixes #714
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.