generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 444
feat(telemetry): add cache usage metrics to OpenTelemetry spans #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JackYPCOnline
merged 1 commit into
strands-agents:main
from
vamgan:feat/add-cache-usage-metrics-to-span
Sep 11, 2025
Merged
feat(telemetry): add cache usage metrics to OpenTelemetry spans #825
JackYPCOnline
merged 1 commit into
strands-agents:main
from
vamgan:feat/add-cache-usage-metrics-to-span
Sep 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5551ab0
to
cb21348
Compare
Can you rebase from main and resolve the conflicts? |
cb21348
to
0623c43
Compare
0623c43
to
1e6ba4d
Compare
done, thanks! |
JackYPCOnline
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution!
zastrowm
approved these changes
Sep 10, 2025
poshinchen
reviewed
Sep 10, 2025
Unshure
approved these changes
Sep 11, 2025
Adds cacheReadInputTokens and cacheWriteInputTokens to span attributes in both end_model_invoke_span and end_agent_span methods to enable monitoring of cache token usage for cost calculation. Closes strands-agents#776
1e6ba4d
to
8779c5a
Compare
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
…nds-agents#825) Adds cacheReadInputTokens and cacheWriteInputTokens to span attributes in both end_model_invoke_span and end_agent_span methods to enable monitoring of cache token usage for cost calculation. Closes strands-agents#776 Co-authored-by: Vamil Gandhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cacheReadInputTokens and cacheWriteInputTokens to span attributes
in both end_model_invoke_span and end_agent_span methods to enable
monitoring of cache token usage for cost calculation.
Closes #776
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.