generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 444
fix(graph): fix cyclic graph behavior #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
previously requested changes
Aug 29, 2025
dbschmigelski
approved these changes
Sep 4, 2025
JackYPCOnline
approved these changes
Sep 5, 2025
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
fix a bug in the Graph multiagent pattern where the reset_on_revisit feature fails to enable cycles and feedback loops. The issue was in the _find_newly_ready_nodes method, which filtered out completed nodes before they could be revisited, making it impossible to implement feedback loops even when reset_on_revisit=True. --------- Co-authored-by: Murat Kaan Meral <[email protected]>Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Graph multiagent pattern where the
reset_on_revisit
feature failed to enable cycles and feedback loops. The issue was in the_find_newly_ready_nodes
method, which filtered out completed nodes before they could be revisited, making it impossible to implement feedback loops even whenreset_on_revisit=True
.Key Changes:
_find_newly_ready_nodes
to accept acompleted_batch
parameter and check conditions against the current batch rather than the global completed nodes state_is_node_ready_with_conditions
to work with the current execution batch instead of relying on global stateTechnical Details:
Related Issues
Fixes #684
Documentation PR
No documentation changes required - this is a bug fix that restores intended functionality.
Type of Change
Bug fix
Testing
How have you tested the change?
Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.