feat: Implement typed events internally #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
requested review from
Unshure and
pgrayy
and removed request for
Unshure
Step 1/N for implementing typed-events; first just preserve the existing behaviors with no changes to the public api. A follow-up change will update how we invoke callbacks and pass invocation_state around, while this one just adds typed classes for events internally.
zastrowm
force-pushed
the
typed_events_rev1
branch
from
d3bbd0a to
0a86928
Compare
zastrowm
commented
Aug 26, 2025
pgrayy
reviewed
Aug 26, 2025
pgrayy
reviewed
Aug 26, 2025
pgrayy
approved these changes
Aug 26, 2025
7 tasks
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
Step 1/N for implementing typed-events; first just preserve the existing behaviors with no changes to the public api. A follow-up change will update how we invoke callbacks and pass invocation_state around, while this one just adds typed classes for events internally. --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
Ratish1
pushed a commit
to Ratish1/sdk-python
that referenced
this pull request
Aug 30, 2025
Step 1/N for implementing typed-events; first just preserve the existing behaviors with no changes to the public api. A follow-up change will update how we invoke callbacks and pass invocation_state around, while this one just adds typed classes for events internally. --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
Step 1/N for implementing typed-events; first just preserve the existing behaviors with no changes to the public api. A follow-up change will update how we invoke callbacks and pass invocation_state around, while this one just adds typed classes for events internally. --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is step 1/N of implementing typed-events - this first PR just preserve the existing behaviors with no changes to the public api by switching call-sites to passing typed classes instead of dictionaries.
A follow-up change will update how we invoke callbacks and pass invocation_state around, while this one just adds typed classes for events internally. It also adds/updates tests to ensure that backwards compatibility is maintained and that typed events are not being emitted to callers out of the agent or the
callback_handlerFollow Up PRs will:
callbackkeys/nesting to burn down tech debtPer discussions with team, we've decided that events will not be part of the public api at this point, so there will not be a pr for releasing these events. For that reason, I'm not overly concerned about:
Related Issues
#242
Documentation PR
N/A - will document after typed events are implemented throughout the code
Type of Change
Other (please describe): Internal refactor
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.