generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 459
Fix/litellm cerebras groq compatibility #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aditya270520
wants to merge
11
commits into
strands-agents:main
Choose a base branch
from
aditya270520:fix/litellm-cerebras-groq-compatibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b82496c
feat: expose user-defined state in MultiAgent Graph
0a8f464
refactor: address reviewer feedback for backward compatibility
aditya270520 1087bd6
Merge branch 'strands-agents:main' into main
aditya270520 caa9d1e
fix: restore missing Swarm methods and fix node object handling
aditya270520 d081102
Merge remote changes
aditya270520 84cebea
style: fix import sorting and formatting issues
aditya270520 b4314f5
style: fix formatting and ensure code quality
aditya270520 a648268
Merge branch 'strands-agents:main' into main
aditya270520 57e167c
fix: resolve LiteLLM compatibility with Cerebras and Groq providers
aditya270520 bf09c05
Merge upstream/main into fix/litellm-cerebras-groq-compatibility
aditya270520 5db9a5b
fix: update LiteLLM format_request method signature and fix test imports
aditya270520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for this but can you help explain where the abstraction is broken.
Are you indicating that LiteLLM has a broken abstraction for Cerebras and Groq? Or do you believe that Strands has always improperly implemented the spec but this was just exposed when Ceregras and Groq were added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @aditya270520, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LiteLLM has a broken abstraction for Cerebras and Groq providers. Strands has always properly implemented the OpenAI specification, but this inconsistency was exposed when Cerebras and Groq were added to LiteLLM's supported providers.
The abstraction should be fixed in LiteLLM itself to ensure all providers receive content in the same format, but until that happens, Strands needs this workaround to maintain compatibility.
This is a common issue when trying to create unified interfaces across multiple providers with different underlying APIs - the abstraction layer (LiteLLM) needs to handle the normalization, but it's not doing so consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#729 (comment)