-
Notifications
You must be signed in to change notification settings - Fork 443
feat: add Gemini model provider #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Gemini model provider #725
Conversation
Would you be able to share a sample test script to test the model provider? :) |
Changes made:
|
…nto gitikavj/add-gemini-model-provider
…nto gitikavj/add-gemini-model-provider
…nto gitikavj/add-gemini-model-provider
…nto gitikavj/add-gemini-model-provider
…nto gitikavj/add-gemini-model-provider
Description
This PR adds the Gemini model provider support to Strands
Related Issues
Documentation PR
TBD -- will edit description once its out
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
pre-commit run --all-files
hatch run prepare
hatch test
-- Wrote new unit tests covering 100% of the gemini src.hatch run test-integ
-- did not get a lot of useful information out of this (most tests skipped because of missing auth keys of those providers) but I did run my own integ test file for gemini that I addedhatch test tests_integ/models/test_model_gemini.py
. They all passNote to reviewer: re: integ tests -- a couple of the integ tests I added for Gemini can get flaky because of the nature of the tests, so I set the temperature to 0.15. They can still fail intermittently. If we do not feel the need to include a bunch of these tests and only include a few to be consistent with the other model provider integ tests, please let me know
Checklist
Follow up
To simplify this PR, we left out a few additional features that Gemini supports. We can handle these in a follow up though.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.