Have [all] group reference the other optional dependency groups by name #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently updated our litellm dependency, but only in the litellm optional dependency, not the [all] group, so fix that + add a test to catch future regressions
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
reviewed
Aug 18, 2025
We recently updated our litellm dependency, but only in the litellm optional dependency, not the [all] group - instead of specifying dependencies twice, have all reference the other optional dependency groups of strands.
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
changed the title
pgrayy
approved these changes
Aug 18, 2025
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently updated our litellm dependency, but only in the litellm optional dependency, not the [all] group - instead of specifying dependencies twice, have all reference the other optional dependency groups of strands
Note
Looks like we're also affected by BerriAI/litellm/issues/13711, so including a fix for that in this PR
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.