-
Notifications
You must be signed in to change notification settings - Fork 445
fix: fix non-serializable parameter of agent from toolUse block #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the example where this bug was exposed, the code that was written was:
The user should not need to pass in the
Then the sdk will automatically add the agent parameter when calling the tool. Additionally, the It should be this:
Not this:
|
@cagataycali if nick's answer makes sense to you, I will close this PR. |
I disagree following statement,
Users can pass any agent instance to direct tool call as agent instance. @Unshure |
…trands-agents#657) Co-authored-by: Harry Wilton <[email protected]>
…rands-agents#643) Previously (strands-agents#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught Co-authored-by: Mackenzie Zastrow <[email protected]>
After discussion, team deceided to strip out any parameter that is not in tool spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…nds-agents#568) * fix: fix non-serializable parameter of agent from toolUse block * feat: Add configuration option to MCP Client for server init timeout (strands-agents#657) Co-authored-by: Harry Wilton <[email protected]> * fix: Bedrock hang when exception occurs during message conversion (strands-agents#643) Previously (strands-agents#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught Co-authored-by: Mackenzie Zastrow <[email protected]> * fix: only include parameters that defined in tool spec --------- Co-authored-by: Jack Yuan <[email protected]> Co-authored-by: fhwilton55 <[email protected]> Co-authored-by: Harry Wilton <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]>
…nds-agents#568) * fix: fix non-serializable parameter of agent from toolUse block * feat: Add configuration option to MCP Client for server init timeout (strands-agents#657) Co-authored-by: Harry Wilton <[email protected]> * fix: Bedrock hang when exception occurs during message conversion (strands-agents#643) Previously (strands-agents#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught Co-authored-by: Mackenzie Zastrow <[email protected]> * fix: only include parameters that defined in tool spec --------- Co-authored-by: Jack Yuan <[email protected]> Co-authored-by: fhwilton55 <[email protected]> Co-authored-by: Harry Wilton <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]>
Description
Before fix:
'input': {'action': 'start_socket_mode', 'agent': <strands.agent.agent.Agent object at 0x1041d9a90>}}}
After fix:
Related Issues
#545
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.