Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/strands/models/bedrock.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def __init__(
boto_session: Optional[boto3.Session] = None,
boto_client_config: Optional[BotocoreConfig] = None,
region_name: Optional[str] = None,
endpoint_url: Optional[str] = None,
**model_config: Unpack[BedrockConfig],
):
"""Initialize provider instance.
Expand All @@ -112,6 +113,7 @@ def __init__(
boto_client_config: Configuration to use when creating the Bedrock-Runtime Boto Client.
region_name: AWS region to use for the Bedrock service.
Defaults to the AWS_REGION environment variable if set, or "us-west-2" if not set.
endpoint_url: Custom endpoint URL for VPC endpoints (PrivateLink)
**model_config: Configuration options for the Bedrock model.
"""
if region_name and boto_session:
Expand Down Expand Up @@ -143,6 +145,7 @@ def __init__(
self.client = session.client(
service_name="bedrock-runtime",
config=client_config,
endpoint_url=endpoint_url,
region_name=resolved_region,
)

Expand Down
33 changes: 25 additions & 8 deletions tests/strands/models/test_bedrock.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def test__init__with_default_region(session_cls, mock_client_method):
with unittest.mock.patch.object(os, "environ", {}):
BedrockModel()
session_cls.return_value.client.assert_called_with(
region_name=DEFAULT_BEDROCK_REGION, config=ANY, service_name=ANY
region_name=DEFAULT_BEDROCK_REGION, config=ANY, service_name=ANY, endpoint_url=None
)


Expand All @@ -139,22 +139,22 @@ def test__init__with_session_region(session_cls, mock_client_method):

BedrockModel()

mock_client_method.assert_called_with(region_name="eu-blah-1", config=ANY, service_name=ANY)
mock_client_method.assert_called_with(region_name="eu-blah-1", config=ANY, service_name=ANY, endpoint_url=None)


def test__init__with_custom_region(mock_client_method):
"""Test that BedrockModel uses the provided region."""
custom_region = "us-east-1"
BedrockModel(region_name=custom_region)
mock_client_method.assert_called_with(region_name=custom_region, config=ANY, service_name=ANY)
mock_client_method.assert_called_with(region_name=custom_region, config=ANY, service_name=ANY, endpoint_url=None)


def test__init__with_default_environment_variable_region(mock_client_method):
"""Test that BedrockModel uses the AWS_REGION since we code that in."""
with unittest.mock.patch.object(os, "environ", {"AWS_REGION": "eu-west-2"}):
BedrockModel()

mock_client_method.assert_called_with(region_name="eu-west-2", config=ANY, service_name=ANY)
mock_client_method.assert_called_with(region_name="eu-west-2", config=ANY, service_name=ANY, endpoint_url=None)


def test__init__region_precedence(mock_client_method, session_cls):
Expand All @@ -164,21 +164,38 @@ def test__init__region_precedence(mock_client_method, session_cls):

# specifying a region always wins out
BedrockModel(region_name="us-specified-1")
mock_client_method.assert_called_with(region_name="us-specified-1", config=ANY, service_name=ANY)
mock_client_method.assert_called_with(
region_name="us-specified-1", config=ANY, service_name=ANY, endpoint_url=None
)

# other-wise uses the session's
BedrockModel()
mock_client_method.assert_called_with(region_name="us-session-1", config=ANY, service_name=ANY)
mock_client_method.assert_called_with(
region_name="us-session-1", config=ANY, service_name=ANY, endpoint_url=None
)

# environment variable next
session_cls.return_value.region_name = None
BedrockModel()
mock_client_method.assert_called_with(region_name="us-environment-1", config=ANY, service_name=ANY)
mock_client_method.assert_called_with(
region_name="us-environment-1", config=ANY, service_name=ANY, endpoint_url=None
)

mock_os_environ.pop("AWS_REGION")
session_cls.return_value.region_name = None # No session region
BedrockModel()
mock_client_method.assert_called_with(region_name=DEFAULT_BEDROCK_REGION, config=ANY, service_name=ANY)
mock_client_method.assert_called_with(
region_name=DEFAULT_BEDROCK_REGION, config=ANY, service_name=ANY, endpoint_url=None
)


def test__init__with_endpoint_url(mock_client_method):
"""Test that BedrockModel uses the provided endpoint_url for VPC endpoints."""
custom_endpoint = "https://vpce-12345-abcde.bedrock-runtime.us-west-2.vpce.amazonaws.com"
BedrockModel(endpoint_url=custom_endpoint)
mock_client_method.assert_called_with(
region_name=DEFAULT_BEDROCK_REGION, config=ANY, service_name=ANY, endpoint_url=custom_endpoint
)


def test__init__with_region_and_session_raises_value_error():
Expand Down
Loading