fix: Update PR Integration Test Workflow #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
previously requested changes
Jun 17, 2025
Unshure
approved these changes
Jun 17, 2025
pgrayy
pushed a commit
to pgrayy/sdk-python
that referenced
this pull request
Jun 18, 2025
* Use deployment environment gating for integration tests. * Only run on PRs that target main. * Use correct head name.
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
* Use deployment environment gating for integration tests. * Only run on PRs that target main. * Use correct head name.
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
* Use deployment environment gating for integration tests. * Only run on PRs that target main. * Use correct head name.
7 tasks
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
* Use deployment environment gating for integration tests. * Only run on PRs that target main. * Use correct head name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a secure check to ensure that the integration tests require approval if the PR creator does not have write access. If the creator has write access or higher, then it will run without approval.
Based on discussion with @Unshure
Related Issues
N/A
Documentation PR
N/A
Type of Change
Testing
Tested in my fork to confirm the permission check works: https://github.com/AdnaneKhan/sdk-python/actions/runs/15708340706/job/44259494661
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.