fix: Update throttling logic to use exponential back-off #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current_delay was being thrown away and not applied to subsequent retries
Unshure
approved these changes
Jun 17, 2025
pgrayy
pushed a commit
to pgrayy/sdk-python
that referenced
this pull request
Jun 18, 2025
…nts#223) current_delay was being thrown away and not applied to subsequent retries Co-authored-by: Mackenzie Zastrow <[email protected]>
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
…nts#223) current_delay was being thrown away and not applied to subsequent retries Co-authored-by: Mackenzie Zastrow <[email protected]>
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
…nts#223) current_delay was being thrown away and not applied to subsequent retries Co-authored-by: Mackenzie Zastrow <[email protected]>
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
…nts#223) current_delay was being thrown away and not applied to subsequent retries Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous to this change,
current_delaywas being thrown away and not applied to subsequent retries meaning that we always slept for the same amount of time instead of applying exponential backoff.Added a test to ensure this going forward.
It looks like this was a bug introduced as part of a previous refactor (a331e63).
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.