Skip to content

fix: ignore mypy error from latest OpenTelemetrySDK update #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

fix: ignore mypy error from latest OpenTelemetrySDK update #180

merged 2 commits into from
Jun 6, 2025

Conversation

@zastrowm
Copy link
Member

@zastrowm zastrowm commented Jun 5, 2025 •
edited
Loading

All PRs in the SDK currently have a mypy linting error: #178:

Run hatch run test-lint
Creating environment: default
Installing project in development mode
Checking dependencies
Creating environment: hatch-static-analysis
Checking dependencies
Syncing dependencies
cmd [1] | ruff check
All checks passed!
cmd [2] | mypy -p src
src/strands/telemetry/tracer.py:16: error: Module "opentelemetry.sdk.resources" has no attribute "Resource"  [attr-defined]
Found 1 error in 1 file (checked 51 source files)

this fixes that.

See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors

@zastrowm
fix: ignore mypy error from latest OpenTelemetrySDK update
e7efa67 
See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors
@zastrowm zastrowm requested a review from a team as a code owner June 5, 2025 20:10
@zastrowm zastrowm merged commit c5eb3ee into strands-agents:main Jun 6, 2025
10 checks passed
@fede-kamel fede-kamel mentioned this pull request Jun 10, 2025
Draft
15 tasks
Unshure pushed a commit to Unshure/sdk-python that referenced this pull request Jul 2, 2025
@zastrowm @Unshure
fix: ignore mypy error from latest OpenTelemetrySDK update (strands-a…
2bc4775 
…gents#180)

See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors

---------

Co-authored-by: Mackenzie Zastrow <[email protected]>
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
@zastrowm @jsamuel1
fix: ignore mypy error from latest OpenTelemetrySDK update (strands-a…
2cc9300 
…gents#180)

See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors

---------

Co-authored-by: Mackenzie Zastrow <[email protected]>
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
@zastrowm @dbschmigelski
fix: ignore mypy error from latest OpenTelemetrySDK update (strands-a…
107a5b8 
…gents#180)

See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors

---------

Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awsarron awsarron awsarron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zastrowm @awsarron