fix(tools): remove deprecated ToolLoader methods #1001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated singular tool loading methods that were marked for removal in Strands SDK 2.0. These methods were deprecated in PR strands-agents#742 in favor of the plural variants that return lists. Removed methods: - ToolLoader.load_python_tool() - use load_python_tools() instead - ToolLoader.load_tool() - use load_tools() instead Also removed: - warnings import (no longer needed) - All tests specific to the deprecated methods The plural methods (load_python_tools and load_tools) remain and should be used instead as they properly handle files with multiple decorated tool functions. Fixes strands-agents#828
ascender1729
requested a deployment
to
manual-approval
GitHub Actions
Waiting
|
Hi, we don't have a 2.0 planned. If and when that occurs we will appreciate the PRs. But because things will surely drift between the impl now and then, and generally to reduce the number of open/stale PRs, I'm going to close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes deprecated singular tool loading methods scheduled for removal in SDK 2.0:
ToolLoader.load_python_tool()ToolLoader.load_tool()Also removes the
warningsimport and all tests for deprecated methods.Migration
Replace deprecated methods with plural equivalents:
Testing
All loader tests pass (1/1 test). 251 tests pass in tools and telemetry modules.
Fixes #828
Breaking change - Users must update to plural methods.