Skip to content

[BUG] only set signature in message if signature was provided by the model #790

@howardzhou

Description

@howardzhou

Checks

  • I have updated to the lastest minor and patch version of Strands
  • I have checked the documentation and this is not expected behavior
  • I have searched ./issues and there are no duplicates of my issue

Strands Version

1.7.0

Python Version

3.12

Operating System

ubuntu 22.04

Installation Method

pip

Steps to Reproduce

Run gpt oss through bedrock

Expected Behavior

Remove this line,
https://github.com/strands-agents/sdk-python/blob/main/src/strands/event_loop/streaming.py#L292

it breaks the fix in previous PR which fixed the model not having signature
https://github.com/strands-agents/sdk-python/pull/682/files

Actual Behavior

GPT oss doesn't have signature, this makes the context messages having 'signature': '', which breaks the bedorck inference

Additional Context

No response

Possible Solution

Remove this line,
https://github.com/strands-agents/sdk-python/blob/main/src/strands/event_loop/streaming.py#L292

See details in PR https://github.com/strands-agents/sdk-python/pull/682/files

Related Issues

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions