Skip to content

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Sep 29, 2017

No description provided.

@fpistm fpistm added bug 🐛 Something isn't working enhancement New feature or request labels Sep 29, 2017
@fpistm fpistm added this to the Next release milestone Sep 29, 2017
@fpistm fpistm requested a review from a user September 29, 2017 15:55
@fpistm fpistm force-pushed the Fix_UART branch 2 times, most recently from 797b7f8 to 88171b6 Compare September 29, 2017 20:06
@fpistm fpistm self-assigned this Oct 1, 2017
ghost
ghost previously approved these changes Oct 2, 2017
@ghost ghost dismissed their stale review October 2, 2017 07:49

There is an error

@ghost ghost self-requested a review October 2, 2017 07:49
#if defined(STM32L0xx)
#if defined(USART4_BASE) || defined(USART5_BASE)
{
HAL_NVIC_ClearPendingIRQ(USART4_IRQn);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name is missing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot. Thanks. Fixed.

@fpistm fpistm requested a review from a user October 2, 2017 09:00
Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm fpistm merged commit 7487390 into stm32duino:master Oct 3, 2017
@fpistm fpistm deleted the Fix_UART branch October 3, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant