Skip to content

Shorten options names to avoid issue with aggressively cache compiled core #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2017
Merged

Shorten options names to avoid issue with aggressively cache compiled core #109

merged 1 commit into from
Sep 21, 2017

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Sep 20, 2017

Fix #108

@fpistm fpistm added the bug 🐛 Something isn't working label Sep 20, 2017
@fpistm fpistm added this to the Next release milestone Sep 20, 2017
@fpistm fpistm self-assigned this Sep 20, 2017
@fpistm fpistm requested review from VVESTM and a user September 20, 2017 21:01
@fpistm fpistm mentioned this pull request Sep 20, 2017
Closed
VVESTM
VVESTM approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@VVESTM VVESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK on my side.
I am now able to use cache option to compile L475 IoT disco examples on my windows machine.
We have now to be careful when adding new options or open a bug on Arduino side...

Thanks @fpistm !!

@fpistm fpistm merged commit eb3c26f into stm32duino:master Sep 21, 2017
@fpistm fpistm deleted the cache_core branch September 21, 2017 08:33
fpistm added a commit to fpistm/stm32_tools that referenced this pull request Sep 21, 2017
@fpistm
Update options name which have been shorten in the core
89f1e31 
See stm32duino/Arduino_Core_STM32#109

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to stm32duino/BoardManagerFiles that referenced this pull request Sep 21, 2017
@fpistm
Update options name which have been shorten in the core
7e6fb8b 
See stm32duino/Arduino_Core_STM32#109

Signed-off-by: Frederic.Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@VVESTM VVESTM VVESTM approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@fpistm fpistm

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
Next release
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @VVESTM