Skip to content

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #550 by cleaning up the summary method and changing it's default sig-fig value to 6

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris March 28, 2022 20:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #551 (902ec71) into develop (ee3692e) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #551      +/-   ##
===========================================
+ Coverage    79.56%   79.70%   +0.13%     
===========================================
  Files           45       45              
  Lines         9705     9735      +30     
===========================================
+ Hits          7722     7759      +37     
+ Misses        1983     1976       -7     
Impacted Files Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py 88.95% <0.00%> (-0.41%) ⬇️
cmdstanpy/cmdstanpy/stanfit/vb.py 94.66% <0.00%> (+0.38%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/vb.py 94.66% <0.00%> (+0.38%) ⬆️
...r/work/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/vb.py 94.66% <0.00%> (+0.38%) ⬆️
cmdstanpy/cmdstanpy/stanfit/mcmc.py 92.84% <0.00%> (+0.46%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/mcmc.py 92.84% <0.00%> (+0.46%) ⬆️
...work/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/mcmc.py 92.84% <0.00%> (+0.46%) ⬆️
cmdstanpy/cmdstanpy/stanfit/mle.py 91.50% <0.00%> (+1.21%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/mle.py 91.50% <0.00%> (+1.21%) ⬆️
.../work/cmdstanpy/cmdstanpy/cmdstanpy/stanfit/mle.py 91.50% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3692e...902ec71. Read the comment docs.

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up this mess!

@WardBrian WardBrian merged commit cc6daf2 into develop Mar 29, 2022
@WardBrian WardBrian deleted the fix/stansummary-defaults branch March 29, 2022 13:28
@WardBrian WardBrian mentioned this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdStanMCMC summary method - don't add default sig_figs=2 in call to subprocess
3 participants