Skip to content
This repository was archived by the owner on Oct 20, 2024. It is now read-only.

fix: Add check for whether account is deployed #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SilasZhr
Copy link

@SilasZhr SilasZhr commented Jul 26, 2023

What?

This PR updates both simpleAccount.ts and gasLimit.ts with initCode issue.

Why?

  • There is an issue when I want to send the first UO if I've deployed account proxy by calling senderCreator or AccountFactory.
  • It always checks the nonce in EntryPoint in Here. But I think user should be able to use EntryPoint with deployed account.

How?

  • check the account code instead of ctx.op.nonce when setting initCode for UO
  • check initCode length before getting factory address from initCode, and return zero for CreationGas if initCode is 0x

Testing?

Passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant