Skip to content

add wait handlers for custom domains and distributions #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2025
Merged

add wait handlers for custom domains and distributions #1823

merged 4 commits into from
Apr 4, 2025

Conversation

@malteehrlen
Copy link
Contributor

@malteehrlen malteehrlen commented Apr 4, 2025 •
edited
Loading

Description

Add wait handlers for CDN resources https://jira.schwarz/browse/STACKITCDN-716

I just saw that a wait handler was already added, please consider this contribution as extending the existing handler with handlers also for custom domains

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@malteehrlen malteehrlen force-pushed the cdn/add_wait_handlers branch 3 times, most recently from a9586cc to 10eff48 Compare April 4, 2025 11:09
@malteehrlen malteehrlen force-pushed the cdn/add_wait_handlers branch from 10eff48 to b4f5448 Compare April 4, 2025 11:13
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 reviewed Apr 4, 2025
View reviewed changes
bahkauv70
bahkauv70 previously approved these changes Apr 4, 2025
View reviewed changes
@malteehrlen malteehrlen force-pushed the cdn/add_wait_handlers branch from 7cc9a32 to c56dc32 Compare April 4, 2025 13:08
@bahkauv70 bahkauv70 merged commit 96f6c33 into stackitcloud:main Apr 4, 2025
8 checks passed
rubenhoenle added a commit that referenced this pull request May 19, 2025
@rubenhoenle
chore(cdn): remove unrelated patchfile
83ff70b 
relates to #1823
@rubenhoenle rubenhoenle mentioned this pull request May 19, 2025
Merged
rubenhoenle added a commit that referenced this pull request May 19, 2025
@rubenhoenle
chore(cdn): remove unrelated patchfile (#2442)
60b3c2c 
relates to #1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceljk marceljk Awaiting requested review from marceljk

@Fyusel Fyusel Awaiting requested review from Fyusel

@rubenhoenle rubenhoenle Awaiting requested review from rubenhoenle

1 more reviewer

@bahkauv70 bahkauv70 bahkauv70 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malteehrlen @bahkauv70 @malte-ehrlen