Skip to content

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Dec 5, 2017

Resolve #56

Also changed dependencies to NLog 4.5, as it will be the next official release.

@strvmarv strvmarv self-requested a review December 5, 2017 22:04
@strvmarv strvmarv self-assigned this Dec 5, 2017
@strvmarv strvmarv removed their request for review December 5, 2017 22:05
@snakefoot
Copy link
Contributor Author

@strvmarv Build is failing with "Specify which project or solution file to use because the folder contains more than one project or solution file."

Is some configuration missing?

https://help.appveyor.com/discussions/problems/6037-specify-which-project-or-solution-file-to-use-because-the-folder-contains-more-than-one-project-or-solution-file

@strvmarv
Copy link
Contributor

strvmarv commented Dec 5, 2017

@snakefoot

Sorry about that...we have two branches running simultaneously at the moment (master & develop) and currently only develop builds via appveyor...

@snakefoot
Copy link
Contributor Author

@strvmarv Should I target the develop-branch instead?

@strvmarv
Copy link
Contributor

strvmarv commented Dec 5, 2017

@snakefoot No, you targeted the correct branch in this case 👍

@snakefoot
Copy link
Contributor Author

I'm curious if the ToLower operation can be skipped for the properties-keys, since ToLower will always allocate a new string (NDC + MDC is using ToLower)

@snakefoot
Copy link
Contributor Author

@strvmarv Added an extra modification by making it possible to disable the scanning for last debug parameter.

@snakefoot
Copy link
Contributor Author

@strvmarv Recognized that LogEvent-Properties/Parameters/Args are different than LogEvent-Context. Have now changed so LogEvent-Properties are prioritized if they are available, and not mixed together with LogEvent-Context-Properties.

Also modified helper method SerializeDebugData to maintain the same behavior on NetCore for generic types.

@snakefoot snakefoot force-pushed the master branch 3 times, most recently from 3ab1293 to f2923d6 Compare December 19, 2017 22:07
@strvmarv strvmarv merged commit 321b6e4 into stackify:master Dec 21, 2017
@strvmarv
Copy link
Contributor

Packages have been updated, but are currently unlisted...you can find them here...

https://www.nuget.org/packages/NLog.Targets.Stackify/2.0.2
https://www.nuget.org/packages/StackifyLib/2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants