Granular control for metric collection #10
+294
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougszumski
force-pushed
the
feature/handle_bad_bmc_output
branch
from
aadc101 to
f992084
Compare
We see an issue where a BMC is reporting 42+ ethernet interfaces and not returning any data for them. This is likely a bug in the BMC FW. This patch allows skipping the collection of certain groups of metrics to work around the bug. It adds an optional configuration section which can be used to control what is collected.
dougszumski
force-pushed
the
feature/handle_bad_bmc_output
branch
from
f992084 to
b71fac4
Compare
|
This will cause conflicts with #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see an issue where a BMC is reporting 42+ ethernet interfaces and not returning any data for them. This is likely a bug in the BMC FW.
This patch allows skipping the collection of certain groups of metrics to work around the bug. It adds an optional configuration section which can be used to control what is collected.
There is no functional change unless you use the new configuration.