Skip to content

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Sep 16, 2024

Adds support for users to specify one or multiple glob patterns in editor.fileTree.allowEdits.

---
type: lesson
title: Example
editor:
  fileTree:
    allowEdits:
      # Items in root
      - "/*"

      # Only "allowed-filename-only.js" inside "/first-level" folder
      - "/first-level/allowed-filename-only.js"

      # Anything inside "second-level" folders anywhere
      - "**/second-level/**"
---

When students attempt to create file that doesn't match these patterns, we show an error dialog:

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@AriPerkkio AriPerkkio force-pushed the feat/allow-edits-globs branch from f0542cf to c4b359b Compare September 17, 2024 11:10
@AriPerkkio AriPerkkio marked this pull request as ready for review September 17, 2024 11:24
@AriPerkkio AriPerkkio requested a review from Nemikolh September 17, 2024 11:31
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work on this! 🤩

Some very minor things, and let's ship this! 💪

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🤩🤩

@Nemikolh Nemikolh merged commit c1a59f5 into stackblitz:main Sep 18, 2024
10 checks passed
@AriPerkkio AriPerkkio deleted the feat/allow-edits-globs branch September 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants