Skip to content

chore: cleanup GA code and more #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2024
Merged

chore: cleanup GA code and more #214

merged 3 commits into from
Mar 28, 2024

Conversation

fvsch
Copy link
Contributor

@fvsch fvsch commented Mar 25, 2024

This PR:

  • Removes support for adding a Google Analytics code snippet with the VITE_GTAG_ID environment variable. We now only support VITE_GTM_ID (for Google Tag Manager).
  • Removes a file that looks like a compilation output that was introduced in feat: add storybook and figma pages #192 (I haven't identified what process generated the file, but we most likely don't want it).

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@stackblitz-staging StackBlitz staging
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for stackblitz-docs ready!

Name Link
🔨 Latest commit bc373b9
🔍 Latest deploy log https://app.netlify.com/sites/stackblitz-docs/deploys/6604d41536085600089f33e2
😎 Deploy Preview https://deploy-preview-214--stackblitz-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

donmckenna
donmckenna approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@donmckenna donmckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@donmckenna donmckenna merged commit 54aa743 into main Mar 28, 2024
@donmckenna donmckenna deleted the fvsch/update-to-gtm branch March 28, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulco sulco Awaiting requested review from sulco

@peter-zawistowicz peter-zawistowicz Awaiting requested review from peter-zawistowicz

1 more reviewer

@donmckenna donmckenna donmckenna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvsch @donmckenna