Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Aug 9, 2025

Description

The remaining TODOs are fixed or removed if not necessary anymore.

Part of #2

Definition of Done Checklist

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Aug 9, 2025
@siegfriedweber siegfriedweber mentioned this pull request Aug 4, 2025
25 tasks
@siegfriedweber siegfriedweber marked this pull request as ready for review August 29, 2025 14:48
@adwk67 adwk67 moved this to Development: In Review in Stackable Engineering Sep 1, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question (that does not need to block the PR). LGTM.

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

@siegfriedweber
Copy link
Member Author

changelog?

I am not sure if a changelog entry is required here. The only user-facing change is that environment variable names in envOverrides are now validated. Other than that, only the code quality was improved.

@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 519f8ce Sep 2, 2025
17 checks passed
@siegfriedweber siegfriedweber deleted the fix/technical-debts branch September 2, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants