-
-
Notifications
You must be signed in to change notification settings - Fork 13
Rework the Lifecycle policies page #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IMO the extremly personal style of this text damages clarity and simplicity. I mean formulations like "our products", "your Kubernetes resources" are pretty vague and don't read very professional. Also there is a bit of callout inflation, like for example:
As a reader I have to wonder: as opposed to what? I know this is a a bit of style preference so I don't expect you to agree. |
modules/ROOT/pages/policies.adoc
Outdated
We support an SDP release for a specific amount of time after its initial release. | ||
|
||
An SDP release contains our operators and other code developed at Stackable as well as the product docker images. | ||
An SDP release contains our operators and other code developed at Stackable as well as the data product docker images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Remove the term "docker" here.
An SDP release contains our operators and other code developed at Stackable as well as the data product docker images. | |
An SDP release contains our operators and other code developed at Stackable as well as the data product container images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1e805e8
modules/ROOT/pages/policies.adoc
Outdated
== CRD Versioning lifecycle policy | ||
|
||
IMPORTANT: As of January 2024 all our CRDs are versioned as `alpha1`. We will start introducing other versions later | ||
IMPORTANT: As of release 25.7 all our CRDs are versioned as `alpha1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This needs to say v1alpha1
.
IMPORTANT: As of release 25.7 all our CRDs are versioned as `alpha1`. | |
IMPORTANT: As of release 25.7 all our CRDs are versioned as `v1alpha1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1e805e8
I believe I have fixed all comments and also tried to address some of the feedback from @razvan. |
No description provided.