-
-
Notifications
You must be signed in to change notification settings - Fork 8
Update monitoring stack to SDP 25.7 and scrape all products #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments about things I encountered while reading through the code or when testing with the monitoring stack. Otherwise LGTM
app.kubernetes.io/name: hdfs | ||
endpoints: | ||
- scheme: http | ||
port: http # Don't use metrics! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "why" to the comment is missing here
# Use something like this to check for metrics: | ||
# count by (app_kubernetes_io_name, app_kubernetes_io_instance, pod) ({app_kubernetes_io_name!="",pod!=""}) | ||
# | ||
# [x] Airflow - exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would add a line above explaining what this list represents or shows. I would assume it's something like "Products metrics covered by the ServiceMonitors below - Metrics origin(?)"
@@ -5,6 +5,289 @@ kind: ConfigMap | |||
metadata: | |||
name: stackable-grafana-dashboards | |||
data: | |||
metric-collection-overview.json: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kafka seems to be missing from the Stacklets and Pods overview
- airflow | ||
- druid | ||
- hive | ||
- kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kafka here in the list but has a separate ServiceMonitor
namespaceSelector: | ||
any: true | ||
selector: | ||
matchLabels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches two services probably, each of the Kafka Pods are scraped twice
# [x] NiFi 1 - native | ||
# [x] NiFi 2 - native | ||
# [ ] OpenSearch - not officially part of the platform yet | ||
# [ ] Spark - native - was too lazy, no idea if we even expose metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spark should have exporter as well as native metrics stackabletech/spark-k8s-operator#582
This is a somewhat big PR, the monitoring stack rotted a bit over the last years and things broke.
This PR cleans everything up and achieves a better state than ever before :)
I now also took the time to look into ServiceMonitors and how they work, so we are able to scrape a lot more of products than before!
NiFi
Kafka