Skip to content

Don't build std_unique_ptr unit tests in C++11 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Don't build std_unique_ptr unit tests in C++11 #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf34fff
cmake: Don't build std_unique_ptr unit tests if CMAKE_CXX_STANDARD is…
jorisv Feb 27, 2024
ef4ac68
changelog: Add changelog entry
jorisv Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Fixed
- Fix unit test build in C++11 ([#442](https://github.com/stack-of-tasks/eigenpy/pull/442))

## [3.4.0] - 2024-02-26

### Added
Expand Down
11 changes: 8 additions & 3 deletions unittest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ add_lib_unit_test(std_vector)
add_lib_unit_test(std_array)
add_lib_unit_test(std_pair)
add_lib_unit_test(user_struct)
add_lib_unit_test(std_unique_ptr)

if(CMAKE_CXX_STANDARD GREATER 14 AND CMAKE_CXX_STANDARD LESS 98)
add_lib_unit_test(std_unique_ptr)
endif()

function(config_test test tagname opttype)
set(MODNAME ${test}_${tagname})
Expand Down Expand Up @@ -137,8 +140,10 @@ add_python_unit_test("py-std-pair" "unittest/python/test_std_pair.py"
add_python_unit_test("py-user-struct" "unittest/python/test_user_struct.py"
"unittest")

add_python_unit_test("py-std-unique-ptr"
"unittest/python/test_std_unique_ptr.py" "unittest")
if(CMAKE_CXX_STANDARD GREATER 14 AND CMAKE_CXX_STANDARD LESS 98)
add_python_unit_test("py-std-unique-ptr"
"unittest/python/test_std_unique_ptr.py" "unittest")
endif()

add_python_unit_test("py-bind-virtual" "unittest/python/test_bind_virtual.py"
"unittest")
Expand Down