add type checking and switch to attrs.define #841
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
#828
Description:
This PR does:
attr.s
toattrs.define
for data class definitionattrs.define
addsslots
to each class but in stac-fastapi we useattrs.make_class
to combine multiple base classes (APIRequest + extensions). Because ofslots
the process will fail withTypeError: multiple bases have instance lay-out conflict
in https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/api/stac_fastapi/api/models.py#L50-L52 . The solution to avoid this is to addslots=False
for each classes 😓FYI: switching to
attrs.define
made type checking happyPR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)