replace attr with dataclass + fastapi.Query() for GET models #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: a6d149b | Previous: 8f400e1 | Ratio |
|---|---|---|---|
Items With Model validation (1000) |
8.55517630649065 iter/sec (stddev: 0.025009408890116516) |
11.339615164306212 iter/sec (stddev: 0.01866654147017851) |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
vincentsarago
changed the title
vincentsarago
commented
Jun 24, 2024
vincentsarago
changed the title
Collaborator
|
This is still a wip? |
Member
Author
|
@jonhealy1 no, this is ready for review. but I'll merge the other PR first |
jonhealy1
requested changes
Jul 1, 2024
Collaborator
jonhealy1
left a comment
jonhealy1
left a comment
There was a problem hiding this comment.
Changelog :) Looks good otherwise
jonhealy1
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #713
closes #638