Skip to content

Conversation

@alukach
Copy link
Contributor

@alukach alukach commented Apr 26, 2023

Description:

An attempt to clean up the logging within the codebase to avoid unnecessary print statements generated during tests unless a higher LOG_LEVEL environment variable is set.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@alukach alukach marked this pull request as ready for review April 26, 2023 22:08
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

We'll need to backport this to https://github.com/stac-utils/stac-fastapi-pgstac/ once #555 is merged, but that's about the same level of difficulty as moving this PR, and as #555 isn't merged yet, I figure it doesn't hurt to merge here.

@gadomski gadomski merged commit 42b5588 into stac-utils:main Apr 28, 2023
@alukach alukach deleted the feature/improved-logging branch April 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants