Skip to content

Use ruff for pre-commit checks; replaces isort and flake8 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 16, 2023
Merged

Use ruff for pre-commit checks; replaces isort and flake8 #549

merged 9 commits into from
May 16, 2023

Conversation

@jpolchlo
Copy link
Contributor

@jpolchlo jpolchlo commented Mar 23, 2023 •
edited by gadomski
Loading

Related Issue(s):
None

Description:
Replaces flake8, isort, and pydocstyle with ruff. All of the changes to *.py files are formatting, no functional changes.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski gadomski self-requested a review March 24, 2023 12:04
@gadomski gadomski added this to the 2.5.0 milestone Mar 24, 2023
gadomski
gadomski requested changes Mar 30, 2023
View reviewed changes
@jpolchlo
Copy link
Contributor Author

jpolchlo commented Apr 17, 2023

@gadomski : Most of the errors encountered here are simple formatting issues, too long lines. You mentioned in passing that there might be automation for fixing these things. Looks like autopep8 doesn't do the job. Any thoughts?

@gadomski
Copy link
Member

gadomski commented Apr 17, 2023

ruff --fix does some work for you. However, I'd recommend waiting on this PR until after #555 lands, as that PR will move a lot of files around and a bunch of formatting fixes will most likely conflict. I'll mark this PR as draft until then.

@gadomski gadomski marked this pull request as draft April 17, 2023 20:09
@gadomski gadomski modified the milestones: 2.5.0, 2.4.7 May 12, 2023
@gadomski gadomski self-assigned this May 12, 2023
@gadomski gadomski marked this pull request as ready for review May 15, 2023 12:43
@gadomski gadomski requested review from gadomski and pjhartzell May 15, 2023 12:44
gadomski
gadomski reviewed May 15, 2023
View reviewed changes
pjhartzell
pjhartzell suggested changes May 16, 2023
View reviewed changes
@gadomski gadomski requested a review from pjhartzell May 16, 2023 12:24
@gadomski gadomski merged commit ced2e43 into stac-utils:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski gadomski approved these changes

+1 more reviewer

@pjhartzell pjhartzell pjhartzell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gadomski gadomski

@jpolchlo jpolchlo

Labels

None yet

Projects

None yet

Milestone

2.4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@jpolchlo @gadomski @pjhartzell